openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

make DynamicDateRange.js control available in forms

Open stesap opened this issue 1 year ago • 4 comments

Change

This change will add support for forms (sap.ui.layout.form.Form) and form container (sap.ui.layout.form.FormContainer) on DynamicDateRange control.

Motivation

The DynamicDateRange control is shown in the UI5 samples page mostly as a filter for a table. It would also be helpful to have this input control in a form as well. At least we tested this successfully in our app and haven't seen any issues so far.

stesap avatar Sep 25 '24 12:09 stesap

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Sep 25 '24 12:09 cla-assistant[bot]

Hello @stesap ,

Thank you for your pull request. I've created an internal record DINC0279997. The status of the issue will be updated here in GitHub.

Regards, Martin

MapTo0 avatar Sep 26 '24 11:09 MapTo0

Hi @stesap,

Could you please share your scenario? Dynamic Date Range could have different value types (e.g. "Yesterday", single date, date range, from/to, etc) which makes it impossible for binding. How you plan to format it after the form validation?

Thanks & Regards, Diana

DMihaylova avatar Sep 27 '24 06:09 DMihaylova

Hi @DMihaylova, in our app we're using the control to provide relative dates:

  • Today
  • First Day of Current Month
  • Last Day of Previous Month (not available in sap.m.StandardDynamicDateRangeKeys)

In addition as we use these values as a relative date in the database, to create schedules for automated runs in the future. Therefore we find it inconvenient for the user, to display a certain date in brackets (see method DynamicDateRange.prototype._enhanceInputValue), which is misleading for our schedule. And the option for last day of previous month is not available.

To support the binding, we implemented a custom type, which does the parsing and formatting. Maybe, it's possible to support these via interfaces and methods which needs to be implemented by developers? Similar to the sap.m.DynamicDateOption where custom options need to implement format/parse/validate methods?

-Steffen

stesap avatar Sep 30 '24 12:09 stesap

This pull request will be tackled via backlog item BGSOFUIBALKAN-8722.

flovogt avatar Feb 11 '25 09:02 flovogt