open-ux-tools icon indicating copy to clipboard operation
open-ux-tools copied to clipboard

add support for exclude annotations as part of app gen

Open kjose90 opened this issue 1 year ago • 3 comments

#1949

  • Added logic in fiori-elements-writer to not add local annotations when excludeAnnotations is true
  • Added option excludeAnnotations to FioriElementsApp type in fiori-elements-writer
  • Added a test to odata-service-writer which generates project when no service annotations are provided

kjose90 avatar May 22 '24 14:05 kjose90

⚠️ No Changeset found

Latest commit: 5c8fd13449a429f59688aeaa98c91efb311a5a05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 22 '24 14:05 changeset-bot[bot]

@kjose90 if understand it correctly then this is for CAP, so I was wondering if it makes more sense to add an option of the annotation format instead of excluding annotations because you would want an annotation.cds file in CAP, correct?

tobiasqueck avatar May 23 '24 13:05 tobiasqueck

@kitzkan if understand it correctly then this is for CAP, so I was wondering if it makes more sense to add an option of the annotation format instead of excluding annotations because you would want an annotation.cds file in CAP, correct?

Thanks @tobiasqueck. We have revised our plan and will add an option to add annotation.cds file if app is CAP 👍

kjose90 avatar May 30 '24 07:05 kjose90

Closing this PR as a revised plan is going to be implemented. The decision was made to write annotation.cds for CAP applications.

kjose90 avatar May 30 '24 07:05 kjose90