open-ux-tools icon indicating copy to clipboard operation
open-ux-tools copied to clipboard

Published 20 hours ago • verified publisher icon SAP

TBI - (fiori-elements-writer): Remove dependency on 'sap.fe.templates' for custom page V4

Open martinjanus-sap opened this issue 1 year ago • 4 comments

Description (include screenshots)

Feedback from our V4 Fiori elements colleagues about changes to the V4 generated projects (regardless of UI5 version):

  • The UI5 dependencies should depend on sap.fe.core for custom page, otherwise in V4 should depend on sap.fe.templates in the manifest.json
  • Remove the manifest.json dependency on sap.ushell, it shouldn't be needed.
  • The generated flpSandbox.html should pre-load sap.fe.core and sap.fe.templates for better performance where possible.

Value

Align with best practice recommendations from V4 Fiori elements.

Architecture Elaboration

Does it requires architecture elaboration?

Notes

Tasks

  • [ ] Task 1

martinjanus-sap avatar May 20 '24 10:05 martinjanus-sap

FYI @tobiasqueck. Might be some middleware updates required as part of this for the flpSandbox.html update.

quiggs1001 avatar May 20 '24 10:05 quiggs1001

@nlunets could you please check this one. I am aware that you are the source for this but I don't think the requirements above are correct, I think it should be more like

  • sap.fe.templates should still be used for LROP
  • sap.fe.core should be used instead of sap.fe.templates if a custom page project is generated
  • ushell should not be in the manifest (that is correct)
  • the test/flp.html should contain templates (and core) to have the best preview expierence - keep in mind the flp.html is only used for local preview, not productively

tobiasqueck avatar May 21 '24 07:05 tobiasqueck

Yes @tobiasqueck you are correct

nlunets avatar May 21 '24 09:05 nlunets

@tobiasqueck @nlunets @ianquigley-sap a few additions:

  1. propose to keep any changes to the preview html files out-of-scope here as their generation is soon be obsolete as we can create them on the fly in the preview middleware, and changes will be done there instead
  2. this BLI has a dependency to an FPM writer enhancement to also maintain the lib section when adding pages, e.g. adding sap.fe.templates when creating a floorplan page like the list report, and adding sap.fe.core for FPM custom pages.

Would this be something you can take together with this BLI as both have to be delivered in sync or shall I create a separate BLI for it?

cfg74 avatar May 22 '24 14:05 cfg74