open-ux-tools
open-ux-tools copied to clipboard
Relax some eslint rules for Fiori TypeScript projects
Relax some overly strict eslint rules for Fiori TypeScript type checking for projects
These eslint type checking was recently introduced in https://github.com/SAP/open-ux-tools/pull/1820/files#diff-9df0c3a37ae50def5595af47d18611f9e0a023feffda9ac694889035c990d6f2R22
However it was a breaking change for existing TypeScript projects. This changes from errors to warnings some of the rules in @typescript-eslint/recommended-requiring-type-checking.
Full list of rules are here:
https://github.com/typescript-eslint/typescript-eslint/blob/51102482255824f335c38e8c02d88f00e2628c13/packages/eslint-plugin/src/configs/recommended-type-checked.ts#L12-L54
🦋 Changeset detected
Latest commit: ccf1066f0348cf59510da8da1c12776187e385da
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @sap-ux/eslint-plugin-fiori-tools | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@devinea can you explain why they are required? Are these errors by default?
@devinea can you explain why they are required? Are these errors by default?
Yeah they are errors by default and I think they are difficult to avoid as often the ui5 type is any especially in tests.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Thanks all.