cloud-sdk-js
cloud-sdk-js copied to clipboard
TypeScript invalid with TS compilerOptions "noImplicitOverride": true
Describe the bug
Generated TypeScript files are not valid when setting "noImplicitOverride": true in tsconfig.json
To Reproduce Steps to reproduce the behavior: git clone https://github.com/GoWale/issue-cloud_sdk-odatav4.git npm i
- Set up ... start the cap server via npm run start
- Execute ... npm run sdk_gen_client (with the running server providing the EDMX)
- See error now you should see the typescript complains in the console
Expected behavior generated typescript should support "noImplicitOverride"
Used Versions:
- node version v20.10.0
- npm version 10.2.5
- SAP Cloud SDK version you used as dependency "@sap-cloud-sdk/generator": "^3.12.1",
Impact / Priority
low / medium: we can add the override by hand or remove the typescript validation
Affected development phase: Development / CI/CD
Hi @GoWale, This config setting is currently not supported. I'll create a ticket to update our client generators.
Hi @deekshas8, it seems we solved this issue with this PR #4687. Could you please confirm?
Closing as this was already fixed in v3.16.0.