cloud-sdk-js icon indicating copy to clipboard operation
cloud-sdk-js copied to clipboard

Support Connectivity Service Secret on Kubernetes out-of-the-box (Node)

Open uwe-klinger opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe.

The Cloud SDK for Java doesn't support service credentials of the SAP BTP connectivity service (connectivity plan proxy) out-of-the-box. The documentation describes required changes that the following 3 properties (example values) need to be added:

onpremise_proxy_host: connectivity-proxy.namespace
onpremise_proxy_http_port: '20003'
url: https://xyz.authentication.xyz.hana.ondemand.com/oauth/token

Describe the solution you'd like

This approach doesn't scale for app development. Instead of this the Cloud SDK should recognize the different configuration structure and has a way to provide the onpremise_proxy_host and onpremise_proxy_port without the need to modify a generated secret. For example using environment variables or using a separate secret that can be statically setup in the application namespace without dependency to the clientid and secret that is generated by the service instance.

Describe alternatives you've considered

Current behavior

Impact / Priority

  • Makes the setup of Kubernetes deployment complicated
  • Increased effort and support

Additional context

I reported the issue for Cloud SDK Java as well: https://github.com/SAP/cloud-sdk/issues/657

uwe-klinger avatar Jan 27 '22 06:01 uwe-klinger

Hey @uwe-klinger thank you for your feedback, I think this is a very good idea and will bring it up to the team.

tomfrenken avatar Jan 27 '22 07:01 tomfrenken

Hey @uwe-klinger, let's see whether we can manage to bring this information into the connectivity proxy by default instead of implementing a workaround. Should this not be possible, this is a great idea. We'll stay in touch on this.

marikaner avatar Jul 18 '22 11:07 marikaner