abap-file-formats icon indicating copy to clipboard operation
abap-file-formats copied to clipboard

[INTS] Add new object type INTS

Open raghav6686 opened this issue 1 year ago • 6 comments

raghav6686 avatar Oct 29 '24 11:10 raghav6686

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Oct 29 '24 11:10 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Oct 29 '24 11:10 cla-assistant[bot]

We have spoken within the team, could you please setup a meeting with me (Guilherme Saraiva), Nicolas Huber and Michael Schneider? We do not usually ask for meeting, but due to the urgency of the delivery and the complexity of the AFF, we think it is best.

GuilhermeSaraiva96 avatar Oct 30 '24 10:10 GuilhermeSaraiva96

I have added several comments now. In a first step, I would focus on structural changes of the AFF like: bindings and binding_mappings or signature*, modeling* and parameter*.

Furthermore, an example would be nice to see the references of INTM to INTS.

I expect more feedback after this iteration.

I've done the changes. Please review and let me know in case of any comments.

raghav6686 avatar Nov 02 '24 10:11 raghav6686

Sentence case means that only the first letter of the first word is capitalised. Sorry that you changed all of the descriptions, they need to be reverted

I've done then changes.

raghav6686 avatar Nov 02 '24 11:11 raghav6686

I had a look at recent changes. But I haven't managed to look into all details, yet. This object has a huge list of fields.

@huber-nicolas gave some input on differences between the title (shorttext description) and the field name. If possible we should keep them in sync. However, whether you change the field name or the title is up to you. I guess, there we see anyhow further suggestions during UX review. But I would keep them in sync already.

schneidermic0 avatar Nov 05 '24 09:11 schneidermic0

@SAP/abap-file-formats-team Can someone else approve this PR, too? I did the last change to it to update the README. Thanks :)

schneidermic0 avatar Apr 25 '25 14:04 schneidermic0