abap-file-formats icon indicating copy to clipboard operation
abap-file-formats copied to clipboard

[SMTG] Add new object type SMTG

Open OliverBeck01 opened this issue 1 year ago • 7 comments
trafficstars

OliverBeck01 avatar Jul 10 '24 15:07 OliverBeck01

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Jul 10 '24 15:07 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Jul 10 '24 15:07 cla-assistant[bot]

missing an example as well

GuilhermeSaraiva96 avatar Jul 10 '24 15:07 GuilhermeSaraiva96

Please expect a delay for the review of this pull request. We have to clarify the language dependent fields of this object.

huber-nicolas avatar Jul 18 '24 14:07 huber-nicolas

Thank you for submitting your object type to the AFF Repository. After detailed discussion with @wurzka @schneidermic0 please go over my comments above and solve them. Please also solve the abaplint issues.

As we discussed in a previous meeting, please remove the ty_template_content, in order to put the language parts into separate files.

huber-nicolas avatar Aug 06 '24 12:08 huber-nicolas

Thank you for the feedback. I changed the requested lines and uploaded the updated documents.

OliverBeck01 avatar Aug 15 '24 09:08 OliverBeck01

Ok, thanks for the update. I'll add the ux-review-ready label so you can continue with the ux review when you are ready.

Markus1812 avatar Oct 22 '24 11:10 Markus1812