abap-file-formats icon indicating copy to clipboard operation
abap-file-formats copied to clipboard

[EDCR] Add new object type for EDCR

Open KUMARMUKULSAP opened this issue 1 year ago • 7 comments

KUMARMUKULSAP avatar Jul 05 '24 05:07 KUMARMUKULSAP

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Jul 05 '24 05:07 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Jul 05 '24 05:07 cla-assistant[bot]

Hi,

Maybe the Pull Request is not yet review-ready, but the AFF contains no information, except for the type name. Is this on purpose?

GuilhermeSaraiva96 avatar Jul 08 '24 13:07 GuilhermeSaraiva96

There are no additional attributes to this object, we only need description of the object

KUMARMUKULSAP avatar Aug 11 '24 16:08 KUMARMUKULSAP

Thank you for your AFF type. Please delete the .DS_Store file and add an example with the name z_aff_example_edcr.edcr.json, even though its nearly empty. Remember to link it in the README.md.

@Markus1812 : I have done these fixes, but i am getting error in checks for examples and README files as "Wrong line endings or no final newline". Can you suggest how can I fix these issues?

KUMARMUKULSAP avatar Aug 28 '24 09:08 KUMARMUKULSAP

Thank you for adapting our suggestions. We have fixed all line endings of the example and README file and added a new line at the end of file.

All checks except Contributor License Agreement are now fulfilled. If you could please check the first comment and perform the necessary actions.

Markus1812 avatar Aug 28 '24 15:08 Markus1812

@Markus1812 : I have signed the CLA agreement.

KUMARMUKULSAP avatar Aug 29 '24 01:08 KUMARMUKULSAP