abap-file-formats icon indicating copy to clipboard operation
abap-file-formats copied to clipboard

[UIAD] Add new object type UIAD

Open aaronbruchsap opened this issue 1 year ago • 3 comments
trafficstars

aaronbruchsap avatar Feb 12 '24 16:02 aaronbruchsap

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Feb 12 '24 16:02 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Feb 12 '24 16:02 cla-assistant[bot]

Check fails due to https://github.com/SchemaStore/schemastore/issues/3620

albertmink avatar Mar 04 '24 14:03 albertmink

Hi @aaronbruchsap, thanks for contributing the UIAD to our repository. I went through your ABAP type and put some comments. Don't be afraid of the number 😉 . Most of them are related to the title case. There are also some questions or suggestions for improvement we maybe want to discuss.

FYI: I think it is done.We commited new changed files and would like to use those for next UX-Review.

ViktoriaFreidel avatar May 06 '24 15:05 ViktoriaFreidel

Feel free to merge, otherwise we will merge by the end of the week.

albertmink avatar May 07 '24 13:05 albertmink

I just re-requested the review of @schneidermic0

albertmink avatar Jun 10 '24 14:06 albertmink