abap-file-formats icon indicating copy to clipboard operation
abap-file-formats copied to clipboard

[SCP1]Remove "Software Component" related fields

Open goreraks opened this issue 1 year ago • 6 comments

Initially we decided to keep "Software Component", "Minimum Release" and "Maximum Release" fields that can be maintained for BC Sets. Because of Software Components are being merged, the code split from S/4 and the issues raised while activating a BC Sets in Steampunk environment, we decided not to keep these fields in AFF.

@wurzka had requested to upload a simple example with lesser in file size. So I will create a seperate PR for the same soon.

goreraks avatar Dec 15 '23 09:12 goreraks

This thing with the example is, the example is no longer valid with the changes in the JSON Schema. As a workaround, you could remove the data in the existing example, softwareComponent, minimumRelease and maximumRelease. Or you add the simplified example to this PR.

albertmink avatar Dec 18 '23 08:12 albertmink

wurzka had requested to upload a simple example with lesser in file size. So I will create a separate PR for the same soon.

I agree with Albert. We should also update the example so that it is at least is compatible with your changes.

schneidermic0 avatar Dec 18 '23 13:12 schneidermic0

Technically, your changes are incompatible. As far as I know SCP1 file format is not available, is it?

schneidermic0 avatar Dec 18 '23 13:12 schneidermic0

Yes, SCP1 file format is not yet available.

goreraks avatar Dec 19 '23 03:12 goreraks

@goreraks There hasn't been any update to this PR for 6 weeks now. When do you plan to fix the example? Without fixing the example we cannot merge this PR in our main branch because we will see failing tests.

schneidermic0 avatar Feb 02 '24 09:02 schneidermic0

No update since more than two months. I have converted this to "draft"

schneidermic0 avatar Feb 23 '24 14:02 schneidermic0