abap-file-formats icon indicating copy to clipboard operation
abap-file-formats copied to clipboard

[SKTD] New object type: Knowledge transfer documents

Open uenal-akkaya opened this issue 3 years ago • 6 comments

uenal-akkaya avatar Dec 05 '21 18:12 uenal-akkaya

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Dec 05 '21 18:12 cla-assistant[bot]

Thanks @uenal-akkaya. I suggest to convert this PR to a draft. Is this fine for you?

schneidermic0 avatar Dec 06 '21 10:12 schneidermic0

@schneidermic0 You can convert this to a draft. Thanks.

uenal-akkaya avatar Dec 06 '21 11:12 uenal-akkaya

@uenal-akkaya Thanks for the update.

The editor configuration shows that there are some whitespaces in empty lines. Are they really necessary. If not, can we remove them?

schneidermic0 avatar Dec 10 '21 12:12 schneidermic0

@uenal-akkaya Thanks for the update.

The editor configuration shows that there are some whitespaces in empty lines. Are they really necessary. If not, can we remove them?

Not sure which the editor configuration is. Can you name them? If you mean the z_aff_example_sktd.sktd.en.md, there the whitespaces in the empty lines are from the documentation text where it was typed that way in the editor.

uenal-akkaya avatar Dec 10 '21 17:12 uenal-akkaya

The repository is checked by an editorconfig file. See https://github.com/SAP/abap-file-formats/blob/34ad66189f7e39bb5aa10cb125f8dd90233b4e43/.editorconfig.

The config checks whether there are any unnecessary whitespace in the code, because this might lead to unnecessary diffs if you compare it to new changes.

schneidermic0 avatar Dec 13 '21 07:12 schneidermic0