abap-file-formats-tools

abap-file-formats-tools copied to clipboard

larshp

Provide checks for ABAP file formats

1

There could be some more automatic checks for validating the ABAP type. E.g., it could be checked whether all types and constants provide a title and a description. See https://github.com/SAP/abap-file-formats/issues/561

schneidermic0

For ranges, it would be great to use the ABAP statement `TYPE RANGE OF` instead of defining own range structures. see sap/abap-file-formats#322

schneidermic0

looks like ZIF_AFF_WRITER~VALIDATE is only used in unit tests?

larshp

rename some of the renamed unit tests

1

rename some of the renamed unit tests from https://github.com/SAP/abap-file-formats-tools/pull/158

larshp

Delete enum related logic

7

the abap-file-formats is [in 702 syntax](https://github.com/SAP/abap-file-formats/blob/main/abaplint.jsonc#L13), so enums are out of scope? suggest deleting the related logic in this repository, less code is easier to get running, plus ENUMS in...

larshp

okay, next suggestion: delete `METHOD is_callback_class_valid.` and just let the code dump if the class is not valid(does not implement the correct interface), the methods in the class are called...

albertmink

enable rule dangerous_statement

2

I've disabled rule [dangerous_statement](https://rules.abaplint.org/dangerous_statement/) in the config suggest refactoring and enabling the rule again suggest that this code, as such, generate the code to memory, where it can be picked...

larshp

larshp

Add method to retrieve object type data and update README format

1

fixes #325

albertmink