cap-sflight icon indicating copy to clipboard operation
cap-sflight copied to clipboard

end to end kyma deployment test for sflight app (Java & Node)

Open 22shubham22 opened this issue 3 years ago • 2 comments

Adding Node and java sflight examples end to end kyma test

Co-authored-by: AnaghaDAnanth [email protected] Co-authored-by: I526683 [email protected]

22shubham22 avatar Aug 23 '22 16:08 22shubham22

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Aug 23 '22 16:08 cla-assistant[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] avatar Aug 23 '22 16:08 cla-assistant[bot]

Hi @chgeo, Please let us know if any changes need to be made. Thank you!

AnaghaDAnanth avatar Sep 07 '22 07:09 AnaghaDAnanth

@uwe-klinger can you review this as a Kyma expert? Or involve someone from our team.

chgeo avatar Sep 07 '22 07:09 chgeo

@22shubham22 can you show in this PR that the workflow works? I have assigned a deploy-kyma label, but the job is still skipped.

It might be that it's because of your PR comes from a fork. If yes, please join the SAP-samples org, and redo the PR from this repo.

@chgeo whom should i reach out to get access to sap samples org ??

22shubham22 avatar Sep 07 '22 16:09 22shubham22

@22shubham22 please go to https://portal.opensource.tools.sap/, join the SAP-samples org. After that, I can add you to the team for this repo.

chgeo avatar Sep 08 '22 07:09 chgeo

@22shubham22 please go to https://portal.opensource.tools.sap/, join the SAP-samples org. After that, I can add you to the team for this repo.

I have joined sap-samples org . Can you please add me as contributor to this repo?

Thanks

MrShubham22 avatar Sep 08 '22 14:09 MrShubham22

It seems you are not: image

Make sure to accept the invitation!

chgeo avatar Sep 08 '22 15:09 chgeo

It seems you are not: image

Make sure to accept the invitation!

22shubham22 is my personal id .

MrShubham22 is the id i made that i connected with sap id and joined sap samples org .

MrShubham22 avatar Sep 08 '22 15:09 MrShubham22

I see. Done.

So then please redo the PR with your new user, not using a fork.

chgeo avatar Sep 08 '22 15:09 chgeo