btp-developer-guide-cap icon indicating copy to clipboard operation
btp-developer-guide-cap copied to clipboard

Set Up Data Collection for SAP Cloud ALM in a CAP Application: Replace base64 encoded version of username:password with environment variable

Open gregorwolf opened this issue 1 year ago • 3 comments

Hello SAP BTP CAP Developer Guide Team,

from the page OpenTelemetry@SAP I was pointed to Enable Data Collection for Real User Monitoring and Health Monitoring. There you mention to create a .npmrc file at the root of the Incident Management application and paste the following:

https://73555000100200018064.npmsrv.cdn.repositories.cloud.sap/:_auth=<base64 encoded version of username:password>

I would suggest to replace that with:

https://73555000100200018064.npmsrv.cdn.repositories.cloud.sap/:_auth=${SAP_NPM_AUTH}

so that the credentials are never stored, the .npmrc file can be checked in and the value is set via an environment variable in the build pipeline or localy.

Best Regards Gregor

gregorwolf avatar Nov 16 '24 09:11 gregorwolf

Hi @shankarigr would be great if this issue could be checked.

gregorwolf avatar May 13 '25 20:05 gregorwolf

Hi @gopalanand333 Could you please have a look at this issue?

Regards, Shankari G R

shankarigr avatar May 19 '25 06:05 shankarigr

Hi @gopalanand333,

in step 1 of Enable Data Collection for Real User Monitoring and Health Monitoring there is still hardcoded credentials. That should not be in an example shoing best practices.

Best regards, Gregor

gregorwolf avatar May 21 '25 07:05 gregorwolf

Hi @gregorwolf
We are working on updating this, It will be done next week.

gopalanand333 avatar Jun 26 '25 10:06 gopalanand333

Hi @gregorwolf Thanks for these inputs. The fix has been merged now. Please feel free to review it and share your feedback.

Best Regards, Gopal

gopalanand333 avatar Jul 29 '25 07:07 gopalanand333

As the fix had been merged. Closing this issue, Please feel free to re-open it if the fix still doesn't resolve the issue

gopalanand333 avatar Sep 23 '25 13:09 gopalanand333