btp-developer-guide-cap
btp-developer-guide-cap copied to clipboard
Set Up Data Collection for SAP Cloud ALM in a CAP Application: Replace base64 encoded version of username:password with environment variable
Hello SAP BTP CAP Developer Guide Team,
from the page OpenTelemetry@SAP I was pointed to Enable Data Collection for Real User Monitoring and Health Monitoring. There you mention to create a .npmrc file at the root of the Incident Management application and paste the following:
https://73555000100200018064.npmsrv.cdn.repositories.cloud.sap/:_auth=<base64 encoded version of username:password>
I would suggest to replace that with:
https://73555000100200018064.npmsrv.cdn.repositories.cloud.sap/:_auth=${SAP_NPM_AUTH}
so that the credentials are never stored, the .npmrc file can be checked in and the value is set via an environment variable in the build pipeline or localy.
Best Regards Gregor
Hi @shankarigr would be great if this issue could be checked.
Hi @gopalanand333 Could you please have a look at this issue?
Regards, Shankari G R
Hi @gopalanand333,
in step 1 of Enable Data Collection for Real User Monitoring and Health Monitoring there is still hardcoded credentials. That should not be in an example shoing best practices.
Best regards, Gregor
Hi @gregorwolf
We are working on updating this, It will be done next week.
Hi @gregorwolf Thanks for these inputs. The fix has been merged now. Please feel free to review it and share your feedback.
Best Regards, Gopal
As the fix had been merged. Closing this issue, Please feel free to re-open it if the fix still doesn't resolve the issue