SAFE-BookStore UI Test failure on .NET Core build verification

Edit:

Full log here: https://github.com/SAFE-Stack/SAFE-BookStore/issues/311#issuecomment-371190446

Environmental info

VS: D15.7stg/27505.3002 (15.7 Preview 1) Node.js: V8.9.4 LTS Yarn --version:1.5.1 Paket version: 5.148.0 VS .NET Core SDK - 2.1.100: 2.1.100 ( runtime - 2.0.5)

Repro steps

Install the needed deps for SAFE-Bookstore and run build.cmd. Error produced:

1) Fake.UnitTestCommon+FailedTestsException: Expecto test of assembly 'C:\Users\CORBVT\AppData\Local\Packages\Microsoft.MicrosoftEdge_8wekyb3d8bbwe\TempState\Downloads\SAFE-BookStore-master\SAFE-BookStore-master\test\UITests\bin\Debug\net461\UITests.exe' failed. Process finished with exit code 2.
   at Fake.Testing.Expecto.Expecto(FSharpFunc`2 setParams, IEnumerable`1 assemblies) in D:\code\fake\src\app\FakeLib\UnitTest\Expecto\Expecto.fs:line 126
   at [email protected](Unit _arg10)
   at Fake.TargetHelper.runSingleTarget(TargetTemplate`1 target) in D:\code\fake\src\app\FakeLib\TargetHelper.fs:line 626

Mar 06 '18 15:03 cartermp

Note: the VS version is likely not needed; it's just there since that's what was installed.

I'm not sure how the UI tests here work with Canopy, but I suspect that this isn't related to the version of the .NET Core SDK that's under test.

Mar 06 '18 16:03 cartermp

can you please give full error? this not showing the actual expectot output

Mar 07 '18 10:03 forki

I confirm that, got this thing when running release script. Full error:

[17:00:16 ERR] client tests/create and remove book errored in 00:02:40.0230000 <Expecto>
OpenQA.Selenium.WebDriverTimeoutException: Timed out!
   at canopy.wait.waitResults[a](Double timeout, FSharpFunc`2 f)
   at canopy.core.op_ComposeLeft[a](a item, String text)
   at [email protected](Unit unitVar0) in C:\Users\pese\Desktop\SAFE-BookStore\test\UITests\Tests.fs:line 85
   at [email protected](Unit unitVar)
   at [email protected](AsyncParams`1 args)
[17:00:16 INF] EXPECTO! 4 tests run in 00:05:08.4797301 - 3 passed, 0 ignored, 0 failed, 1 errored.  <Expecto>
[ERROR - 2018-03-07T16:00:17.740Z] RouterReqHand - _handle.error - {"stack":"_translateKey@phantomjs://code/inputs.js:268:55\n_sendKeys@phantomjs://code/inputs.js:217:42\n_postValueCommand@phantomjs://code/webelement_request_handler.js:288:41\n_handle@phantomjs://code/we
belement_request_handler.js:72:30\n_reroute@phantomjs://code/request_handler.js:61:20\n_handle@phantomjs://code/session_request_handler.js:120:42\n_reroute@phantomjs://code/request_handler.js:61:20\n_handle@phantomjs://code/router_request_handler.js:78:46","line":268,"so
urceURL":"phantomjs://code/inputs.js"}

  phantomjs://platform/console++.js:263 in error
[INFO  - 2018-03-07T16:00:17.794Z] ShutdownReqHand - _handle - About to shutdown
Running build failed.
Error:
Expecto test of assembly 'C:\Users\pese\Desktop\SAFE-BookStore\test\UITests\bin\Debug\net461\UITests.exe' failed. Process finished with exit code 2.
Starting FinalTarget: KillProcess
Searching for processes with name = dotnet
Trying to kill process dotnet (Id = 13372)
Trying to kill process dotnet (Id = 5880)
Searching for processes with name = dotnet.exe

---------------------------------------------------------------------
Build Time Report
---------------------------------------------------------------------
Target              Duration
------              --------
Clean               00:00:00.0965289
InstallDotNetCore   00:00:00.2429785
InstallClient       00:00:03.2913431
SetReleaseNotes     00:00:00.0049714
BuildServer         00:00:04.3700232
BuildClient         00:00:28.4515895
BuildServerTests    00:00:06.4289201
RunServerTests      00:00:09.4134053
BuildClientTests    00:00:03.0007435
RenameDrivers       00:00:00.0009485
KillProcess         00:00:00.0317423
RunClientTests      Failure
Total:              00:06:35.0042812
---------------------------------------------------------------------
Status:             Failure
---------------------------------------------------------------------
---------------------------------------------------------------------
  1) Fake.UnitTestCommon+FailedTestsException: Expecto test of assembly 'C:\Users\pese\Desktop\SAFE-BookStore\test\UITests\bin\Debug\net461\UITests.exe' failed. Process finished with exit code 2.
   at Fake.Testing.Expecto.Expecto(FSharpFunc`2 setParams, IEnumerable`1 assemblies) in D:\code\fake\src\app\FakeLib\UnitTest\Expecto\Expecto.fs:line 126
   at [email protected](Unit _arg10)
   at Fake.TargetHelper.runSingleTarget(TargetTemplate`1 target) in D:\code\fake\src\app\FakeLib\TargetHelper.fs:line 626
---------------------------------------------------------------------

Mar 07 '18 16:03 psfinaki

Workaround for release: comment/remove ==> "RunClientTests" and ==> "TestDockerImage" in the build script with all the consequences.

Mar 07 '18 16:03 psfinaki

Thanks for the repro @psfinaki - I've been running around over the past day and haven't had the time to get the full error.

Mar 07 '18 16:03 cartermp

@psfinaki is it that canopy can't find the remove button?

@cartermp are you sure it's the same thing?

Mar 07 '18 19:03 forki

@forki, I do not know actually, it might take quite some time for me to understand.. I have not worked with canopy before and also still have a vague idea how things work and get tested here.

Mar 07 '18 19:03 psfinaki

No problem. I was seeing that "remove" error today on one of my machines. So I was wondering if it's the same. But it does not happen on CI.

Mar 07 '18 19:03 forki

I suspect it may be the same; I can try it again sometime later this week but between MVP summit and dealing with our apartment getting sold I'm short for time this week 😢

Mar 07 '18 22:03 cartermp

don't worry. let's assume it's the same and fix. after a while you can check if you still see the error ;-)

Mar 08 '18 06:03 forki

Sounds like a good plan!

Mar 08 '18 07:03 cartermp

Repro on D16.0/28322.00 (16.0 preview 1.0)