SAFE-BookStore icon indicating copy to clipboard operation
SAFE-BookStore copied to clipboard

Failure on first-time build

Open dsyme opened this issue 7 years ago • 5 comments

Steps

  • Fork + clone master a669d99a279c1be112c4e4f9d2f230fd9c7e36c1
  • .\build.cmd

Got this:

image

dsyme avatar Jan 25 '18 13:01 dsyme

seems like the UI Tests fail since some UI elements have been changed, but the tests have not been updated. As a workaround you can simply comment them out in build.fsx to get it working. I will try to fix it.

Target "Build" DoNothing
Target "All" DoNothing

"Clean"
  ==> "InstallDotNetCore"
  ==> "InstallClient"
  ==> "SetReleaseNotes"
  ==> "BuildServer"
  ==> "BuildClient"
  ==> "BuildServerTests"
  ==> "RunServerTests"
  // ==> "BuildClientTests"
  // ==> "RenameDrivers"
  // ==> "RunClientTests"
  ==> "BundleClient"
  ==> "All"
  ==> "CreateDockerImage"
  ==> "TestDockerImage"
  ==> "PrepareRelease"
  ==> "Deploy"

ghost avatar Jan 25 '18 14:01 ghost

I investigated and the UI elements are in sync with the tests. I think something got messed up with user state on the client side. Probably the page gets rendered empty like in #274

ghost avatar Jan 25 '18 14:01 ghost

BTW switched to do build run and everything was ok from the first-time user perspective. I hadn't seen the need for ``run`

dsyme avatar Jan 25 '18 19:01 dsyme

The "build run" is what starts everything in watch mode or what I like to call "all the time Mode".

Am 25.01.2018 20:07 schrieb "Don Syme" [email protected]:

BTW switched to do build run and everything was ok from the first-time user perspective. I hadn't seen the need for ``run`

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SAFE-Stack/SAFE-BookStore/issues/278#issuecomment-360567455, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNGOEmnZeLr3JdameVkzSThjvesRgks5tONDTgaJpZM4Rs23D .

forki avatar Jan 25 '18 19:01 forki

yeah and it is an incredible development experience.

I am also impressed with the deployment and release stuff you get out of the box (this is really important for adoption of commercial use I think). Release + Tag on GitHub, push to Docker Registry and deployment to Google Cloud an Azure with 2 commands once everything is set up. Awesome!

@forki I think you can close it, since client tests pass again with #279 and just calling ./build.cmd works fine

ghost avatar Jan 25 '18 19:01 ghost