Ryujinx icon indicating copy to clipboard operation
Ryujinx copied to clipboard

Global memory emulation using NV_shader_buffer_store and DrawElementsIndirect macro HLE

Open gdkchan opened this issue 3 years ago • 10 comments

This is mostly a bunch of changes/fixes to get Nintendo Switch Sports working. I don't plan to get this specific PR merged, instead each change should be PRed and tested individually later.

This includes the following changes:

  • New approach for global memory emulation. This approach works for games that passes GPU pointers to the shader and access them directly. It requires NV_shader_buffer_store OpenGL extension that is only supported by NVIDIA, so it won't work on other vendors.
  • HLE macro for DrawElementsIndirect. Not necessary to make it work, but it improves the performance.
  • Some shader fixes related to geometry shader passthrough.

This change allows the game to go in-game on NVIDIA as you can see on the screenshots below. image image image

gdkchan avatar Apr 29 '22 19:04 gdkchan

Even with 1.0.0+9203702 (winx64 version), the game crash after we launch a party (launch any game or motion controls calibration always failed or go to avatar creator or both of them) and joyconpair always required even in game with 1 joycon.

Log : Ryujinx_1.1.0+9203702_2022-04-30_15-44-25.log

marmarbrrr avatar Apr 30 '22 13:04 marmarbrrr

Nintendo Switch Sports: Needs ignore missing services (ref: Discord Message)

list of issues found: Random freezing in loading screens (no error in the log) (ref: Discord Message) Some of the games don't use motion correctly

piplup55 avatar May 03 '22 02:05 piplup55

try with real joycons and emulator pop up message with bad config to player1 player2 player3 player4 i have try all but unable to start any party

Alyasa42 avatar May 06 '22 10:05 Alyasa42

even when im running ryujinx 1.0.0 9203702 (win_x64) the game crashes when i try to start a game.

QstTheDuck avatar May 07 '22 13:05 QstTheDuck

even when im running ryujinx 1.0.0 9203702 (win_x64) the game crashes when i try to start a game.

you need to enable ignore missing services in the settings

Niwu34 avatar May 07 '22 13:05 Niwu34

If i play Nintendo Switch Sports game has been very strange.

Ryujinx_1.1.0+9203702_2022-05-11_18-50-29.log

  • Ryujinx version: 1.1.0+9203702
  • Game version: 1.1.0
  • System Specs:
    • OS: Microsoft Windows 10.0.18362 (X64)
    • CPU: AMD Ryzen 5 3600 6-Core Processor
    • GPU: NVIDIA GeForce GTX 750
    • RAM: 16307 MB
  • Applied Mods : No

Dymkar avatar May 11 '22 16:05 Dymkar

Tested a multitude of games (HWDE, SMO, MK8D) and didn't notice any crashes with this PR.

MelonSpeedruns avatar May 12 '22 14:05 MelonSpeedruns

Is there anyway to enable the artifacts on this? Looks like it expired 2 days ago and this fix hasn't been rolled up yet.

Iceflow420 avatar Jul 30 '22 20:07 Iceflow420

pls reploud the artifacts

AzevedoForce avatar Aug 19 '22 08:08 AzevedoForce

Superseded by #4047.

gdkchan avatar Dec 06 '22 21:12 gdkchan