DS4Windows icon indicating copy to clipboard operation
DS4Windows copied to clipboard

DS4Windows creating a problem with the latest update

Open Julinkk opened this issue 1 year ago • 10 comments

I do each update but since the last one (3.3.0) my saved profiles no longer load. If I launch a program it loads the profile but when I close the program it remains stuck on this profile and no longer loads any others.

Julinkk avatar Dec 18 '23 16:12 Julinkk

I just did the 3.3.1 update and the problem persists.

Julinkk avatar Dec 21 '23 18:12 Julinkk

Currently experiencing the same issue with version 3.3.1 of DS4Windows, using a Dualsense Edge. Right after starting DS4Windows, the first executable that has an automatic profile tied to it will be detected as normal. Afterwards, when trying to open another software which has a different profile set for it, that new profile will not be loaded.

EDIT: Can confirm that on my system reverting to 3.2.21 fixes this.

Ryunam avatar Dec 22 '23 22:12 Ryunam

I have tested several games with auto-profiles (some even switching from XInput to DInput) and I can't reproduce this problem.

For info I'm using a DS4 v2.

Ryusennin avatar Dec 23 '23 00:12 Ryusennin

I confirm this problem. Auto profiles don't work. Profile switching occurs once and only after restarting DS4W. I checked it on a clean versions 3.3.0-3.3.2. Version 3.2.21 is OK. Win10x64, Dualsense, DS4v1.

Basfet avatar Dec 23 '23 13:12 Basfet

Was experiencing the same issue here. Tried creating new profiles and was still getting the same result. Would switch once but would not switch again.

Looking in the log I noticed that the log consistently stopped when it changed controller 2. In the past I remember this showing changing all controllers whether they were connected or not but this time it only showed controllers 1 and 2. At this time I only had one controller connected. Found that the issue appears to be resolved if I change the auto profiles to only change for controller 1.

Went back and reconfigured again with controllers 1 and 2 for each of the auto profiles and it was working as long as both controllers were connected.

I found if I rolled back to 3.2.21 the auto profiles switched without issue. Is it possible changes after 3.2.21 might throw an error if the auto profiles settings attempt to change a controller that is not connected?

vdicrocco avatar Dec 27 '23 19:12 vdicrocco

Interesting, to do with Ryochan

Julinkk avatar Dec 27 '23 20:12 Julinkk

That would be an oversight. The current routine would only work for currently connected controllers. The routine is skipped if a device does not exist for a slot.

This is a change that should be made for the last version.

Ryochan7 avatar Dec 28 '23 17:12 Ryochan7

Not at my main PC right now but I want to think that I did take into account whether an input device is connected to an input slot. The load profile would change accordingly. I will look into it regardless.

Ryochan7 avatar Dec 28 '23 17:12 Ryochan7

Back on my main PC now. I already see a big whoops. Copy pasta'd the device available routine and I did not delete the outlining call that depends on a existing device. A device check was being done before so that part was not missed.

Ryochan7 avatar Dec 28 '23 21:12 Ryochan7

https://github.com/Ryochan7/DS4Windows/commit/50011298f6efa3c00171e0135e733ca7fc56e154

Ryochan7 avatar Dec 28 '23 21:12 Ryochan7