DiffusionToolkit icon indicating copy to clipboard operation
DiffusionToolkit copied to clipboard

increase max image/page to 2000

Open laurentopia opened this issue 2 years ago • 2 comments

Currently capped at 500. Too arbitrary.

laurentopia avatar Jun 24 '23 18:06 laurentopia

Ultimately, it's a performance question. Right now, on my machine, 250 gives a decent experience when paging. It also may not be entirely up to machine speed, but also how .NET renders stuff.

The thumbnail generation code could use a bit more work and should ideally only generate thumbnails when the thumbnail becomes visibile. I haven't gotten it to do this properly.

I'd probably need to rewrite the whole thumbnail viewer to make it really performant, and rely less on WPF binding.

I can change the max, but I didn't want people complaining about the slow performance of the thumbnail viewer when they do max it.

RupertAvery avatar Jul 28 '23 02:07 RupertAvery

I wonder if old schoold optims can be used:

  1. These are jpg so you can load only the lowest frequency domains
  2. the screen only shows few images so combined clipping the loading + display with only loading lowest frequency domains of the jpg should substantially boost speed

laurentopia avatar Aug 11 '23 18:08 laurentopia