Tensor icon indicating copy to clipboard operation
Tensor copied to clipboard

Update prototypes in extension code

Open myfluxi opened this issue 2 years ago • 7 comments

Fixes a few deprecation warnings such as

Return type of Tensor\Vector::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

myfluxi avatar Apr 07 '23 19:04 myfluxi

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Apr 07 '23 19:04 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

myfluxi avatar Apr 07 '23 19:04 myfluxi

Hey this is great @myfluxi, I'll take a look at this ASAP

andrewdalpino avatar Apr 20 '23 23:04 andrewdalpino

Seems something is broken here ?

FxNion avatar Apr 27 '23 07:04 FxNion

It is an unrelated test failing later in the process. This patch fixes some warnings which at least lets the extension compile during testing.

myfluxi avatar Apr 28 '23 07:04 myfluxi

The problem with this PR is that the code in the ext directory is automatically generated by zephir starting from the code in the tensor directory.

So, the fix should be performed in the tensor directory, like I'm suggesting in #39 (in particular, see 49f8b9e12ccf3d9570e859f0ff770f9b9f0d3282).

mlocati avatar Sep 14 '23 06:09 mlocati

Hey thanks fellas, much appreciated! Do we still need this code since we merged @mlocati's code?

andrewdalpino avatar Sep 20 '23 05:09 andrewdalpino

Closing this because I think this issue has been solved in a different PR.

andrewdalpino avatar May 06 '24 21:05 andrewdalpino