ML icon indicating copy to clipboard operation
ML copied to clipboard

move tools to a separate directory

Open mcharytoniuk opened this issue 1 year ago • 4 comments

The goal is to avoid dependencies between tools.

For example the latest phpstan and the latest phpunit depend on a different version of https://github.com/sebastianbergmann/diff

Also it won't cause as many potential dependency conflicts between RubixML and the end user projects.

I modified composer.json, so scripts should work exactly as before (for example composer anayze runs phpstan).

I made an exception for phpunit, so phpstan can still analyze the test files.

Next step would be to also add https://github.com/rectorphp/rector to the tools directory and update phpunit to v11 (tbd in a different PR)

mcharytoniuk avatar Feb 07 '24 22:02 mcharytoniuk

Is this solving a problem that we have currently? Or a potential one in the future?

andrewdalpino avatar Feb 12 '24 06:02 andrewdalpino

@andrewdalpino it solves the current problem: I can't use the latest PHPUnit version alongside the latest PHPStan because they conflict with the required https://github.com/sebastianbergmann/diff library version.

I want to upgrade PHPUnit, because the current version reaches EOL in the February (at least end of bugfix support): https://phpunit.de/supported-versions.html

I'm just stuck in a dependency hell - I wanted to decouple all those tooling dependencies from the core codebase. :D

mcharytoniuk avatar Feb 12 '24 06:02 mcharytoniuk