Rocket.Chat.ReactNative
Rocket.Chat.ReactNative copied to clipboard
fix: iOS build broken in Xcode 16
Proposed changes
Fixes for iOS build broken on Xcode 16
Issue(s)
#5877
How to test or reproduce
Screenshots
Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [x] Improvement (non-breaking change which improves a current function)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Documentation update (if none of the other choices apply)
Checklist
- [x] I have read the CONTRIBUTING doc
- [x] I have signed the CLA
- [x] Lint and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
- [ ] I have added necessary documentation (if applicable)
- [ ] Any dependent changes have been merged and published in downstream modules
Further comments
Hi, using this PR does indeed fix the building of the iOS app. OS: Sequoia 15.0.1 on arm Xcode: 16.0 Rocket Chat Community Ver: 6.13.0 on docker
Like to say thanks! At least I have a version out in my build.
However, the app that was build out, when trying to take a picture and upload, it is compressed and does not take into account the setting in rocket chat. Any advice on that?
Android build does not have this issue, so most prob is some of the changes in this PR that causes the compression of the pictures being sent ( server setting is do not compress ) Settings > Message > Message attachments ( off )