Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

fix: CookieManager domain value handled port case

Open hcoz opened this issue 1 year ago • 5 comments

Proposed changes

Jitsi meeting view won't open if the server url has a port value because CookieManager throws a "domain and server url don't match" error. This is fixed by removing the port value from the domain if it exists. Also moved the setCookie method to useEffect as suggested by react.

Issue(s)

https://github.com/RocketChat/Rocket.Chat.ReactNative/issues/5852

How to test or reproduce

Try joining a jitsi meeting in a workspace that has a server url with a port like www.my-workspace.com:8080.

Screenshots

Types of changes

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [x] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

hcoz avatar Sep 21 '24 16:09 hcoz

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


EXT02D057618 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 21 '24 16:09 CLAassistant

@hcoz Do you have a Jitsi server we can use to test? Otherwise it may take a while for us to review this PR, since we're not used to running local Jitsi servers.

diegolmello avatar Sep 23 '24 14:09 diegolmello

Hi @diegolmello, Unfortunately, I cannot provide it for testing as I am working on my client's server.

hcoz avatar Sep 24 '24 06:09 hcoz

Please review 🙏

DustpaN-Spb avatar Oct 17 '24 06:10 DustpaN-Spb

@DustpaN-Spb can't review without a test server. We can create one, but it's going to take a while, since it's a low priority. If we had a server, we could do it right away.

diegolmello avatar Oct 17 '24 13:10 diegolmello

Any updates?

DustpaN-Spb avatar Jan 27 '25 08:01 DustpaN-Spb

As per previous comments, we need a Jitsi server for testing because it's going to take long to setup one.

Rohit3523 avatar Jan 27 '25 09:01 Rohit3523