Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

Feat: Add sorting functionality in directory

Open brf153 opened this issue 1 year ago • 4 comments

Description:

There is no sorting functionality in the mobile app whereas it is present in the browser and desktop app. I think it will be a good feature to add.

Environment Information:

  • Rocket.Chat Server Version: 6.5
  • Rocket.Chat App Version: 4.45.0.99999999
  • Device Name: Samsung Galaxy M13 5G
  • OS Version: Ubuntu 22.04
  • Android Version: 13

Steps to reproduce:

  1. Go to the directory in the mobile app as well as the browser.
  2. Notice that there is no sort functionality in the mobile app but it is present there in the browser.

Expected behavior:

Sorting present in the directory just like in the browser or desktop app

Screenshot from 2023-12-22 08-26-24

Actual behavior:

No sorting in the directory

WhatsApp Image 2023-12-22 at 08 30 58

brf153 avatar Dec 22 '23 03:12 brf153

@diegolmello I hope to contribute to addressing this issue by suggesting a new feature. I propose adding a filter icon next to the dropdown arrow and implementing two sorting functionalities: one for sorting by name and another for sorting by user. I believe this addition would enhance the overall functionality of the system. May I have the opportunity to work on this?

brf153 avatar Dec 22 '23 03:12 brf153

Hey @brf153. Sure, go for it :)

diegolmello avatar Dec 22 '23 13:12 diegolmello

Hey @diegolmello, I have worked on this issue and created a pull request #5442 which adresses the specified concerns. I would really appreciate for you to take a review on the changes I made.

Thank you.

preeesha avatar Dec 27 '23 17:12 preeesha

@GuptaPrisha Hello Prisha. Actually I have already worked on this issue. I just need to make a commit and push it. I was just travelling back to my college and could not finish the work in time.Please understand that you should first check whether someone else is working or has already worked on this issue before or not. You are simply not respecting the work culture which needs to be followed in the open source community which contributing.

brf153 avatar Dec 27 '23 17:12 brf153