Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

[FIX] Solving the navigation issue from threads on tablets

Open samay-kothari opened this issue 3 years ago • 5 comments

Proposed changes

When navigating from a thread in a room to a different room directly using the side pane on tablet was not unsubscribing the current room. This fix makes sure that the user is not subscribed to more than one room at a single time. It removes the extra room from the room redux component.

Issue(s)

Closes #3969

How to test or reproduce

Screenshots

https://user-images.githubusercontent.com/55805094/162345029-6961b8dd-26d5-4f25-ab15-e92140c2b010.mov

Types of changes

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

samay-kothari avatar Apr 08 '22 01:04 samay-kothari

Hi @gerzonc, Can you review this?

samay-kothari avatar Apr 16 '22 09:04 samay-kothari

@gerzonc @diegolmello @GleidsonDaniel hey! Is there a plans to land that fix to next release? Thanks!

ankar84 avatar Jun 08 '22 05:06 ankar84

Any news?

ankar84 avatar Sep 28 '22 10:09 ankar84

@ankar84 This is not the best way to fix it, so I need to try another way. For example, disabling nested rooms (Room A opening Room B) would solve this by default.

diegolmello avatar Sep 28 '22 11:09 diegolmello

@ankar84 This is not the best way to fix it, so I need to try another way. For example, disabling nested rooms (Room A opening Room B) would solve this by default.

ok. I get it. Waiting for a proper fix then. Thank you, Diego!

ankar84 avatar Sep 28 '22 13:09 ankar84