Rocket.Chat.ReactNative icon indicating copy to clipboard operation
Rocket.Chat.ReactNative copied to clipboard

[Improvement] The order of the mentions now shows the room participants first then outsiders.

Open samay-kothari opened this issue 3 years ago • 5 comments

Proposed changes

The order of mentions in the mobile app used to be according to recent conversation, but now before that the priority is given to the participants of the room. The order followed is as it is done in the web-app as mentioned here

Issue(s)

Fixes #3681

How to test or reproduce

Screenshots

https://user-images.githubusercontent.com/55805094/161386718-7f8d2ef1-e418-4b69-8e4a-31a7e9a9df02.mp4

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] Improvement (non-breaking change which improves a current function)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Documentation update (if none of the other choices apply)

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ ] I have added necessary documentation (if applicable)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

samay-kothari avatar Apr 04 '22 18:04 samay-kothari

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 04 '22 18:04 CLAassistant

Hello, Team! Is that PR planed to land in 4.27?

ankar84 avatar Apr 15 '22 06:04 ankar84

@gerzonc @diegolmello @GleidsonDaniel hey! Is there a plans to land that fix to next release? Thanks!

ankar84 avatar Jun 08 '22 05:06 ankar84

@gerzonc @diegolmello @GleidsonDaniel hello, team! Any updates about that PR? That improvement is very useful and in general imply algorithm that already working in Web client for a year or even more. It is providing same level of functionality of Web and Mobile clients. And I guess Mobile client should go in that direction. Thanks!

ankar84 avatar Aug 26 '22 07:08 ankar84

@gerzonc @diegolmello @GleidsonDaniel hello, team! Any updates about that PR? That improvement is very useful and in general imply algorithm that already working in Web client for a year or even more. It is providing same level of functionality of Web and Mobile clients. And I guess Mobile client should go in that direction. Thanks!

This PR was out of my radar. It needs some polishing, like we should reuse the logic for the normal spotlight instead of fragmenting usage. I'm going to add to next sprint, so we can review and finish it. Thanks for pinging.

diegolmello avatar Aug 26 '22 13:08 diegolmello