Rocket.Chat.Apps-engine icon indicating copy to clipboard operation
Rocket.Chat.Apps-engine copied to clipboard

Fixed Masked SettingType

Open ashnove opened this issue 2 years ago • 5 comments

This closes https://github.com/RocketChat/Rocket.Chat.Apps-engine/issues/238

The fix/hack I've added is to append a PASSWORD attribute to the SettingType enum and used it in the provideSetting configuration.

ashnove avatar Feb 04 '23 23:02 ashnove

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: ashnove
:white_check_mark: d-gubert
:x: casalsgh
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 04 '23 23:02 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 04 '23 23:02 CLAassistant

Is this a duplicate of #577?

graywolf336 avatar Feb 06 '23 14:02 graywolf336

Is this a duplicate of #577?

Seems like it

ashnove avatar Feb 07 '23 05:02 ashnove

Just the first part - My PR only adds password to the list, but doesn't change any setting to use it.

pierre-lehnen-rc avatar Feb 08 '23 16:02 pierre-lehnen-rc