[BUG] Cannot deploying apps: write after end

[cuonghuunguyen]

When deploy/updating apps by Rocket.Chat/Apps-CLI, the console shows the error write after end without any logs from server side.

Additional information:

• RC: 5.4.1
• rc-cli: rocket.chat/apps-cli/1.10.1 wsl-x64 node-v14.21.1
• Apps-Engine version: latest

[debdutdeb]

@dudanogueira :eyes:

[cuonghuunguyen]

hi, any updates abt this issue? it seems to be a critical bug for apps developers

[dudanogueira]

Hi! Is this code public?

I indeed noticed some situations with different error messages, or sometimes the code not being executed and no errors showing, but I forgot to note the code or isolate it to create a reproducible environment to handle over to the apps engine devs.

And now I can't produce this errors again :)

[cuonghuunguyen]

yes, could you have a look at my Birthday app in my repo list?

[cuonghuunguyen]

https://github.com/cuonghuunguyen/Rocket.Chat.Apps-Birthday I can reproduce this in the latest version

[cuonghuunguyen]

Any updates on this issue?

[cuonghuunguyen]

The error happened in getUploadFormData.ts and this line

const bb = busboy({ headers: request.headers, defParamCharset: 'utf8', limits });

[cuonghuunguyen]

Seems to be a bug from vm2 implementation

[casalsgh]

@cuonghuunguyen would you mind trying to reproduce this again on the latest version (6.1.4)? We had some improvements to vm2 and fixed some other apps related errors. Hope the experience is better now

[cuonghuunguyen]

sure, will inform you as soon as I have the result

[cuonghuunguyen]

Still reproducable. Rocket.Chat 6.1.5 Community edition Docker installation

[cuonghuunguyen]

Investigated and found the problem, the vm2 will cause the memory leak when running axios.