Rocket.Chat.Apps-engine
Rocket.Chat.Apps-engine copied to clipboard
Implement the IRoomRead get messages function
What? :boat:
- Change the IterableIterator to AsyncIterableIterator.
Why? :thinking:
This way we can fetch the messages one at a time from the database instead of all the time.
Links :earth_americas:
This one replaces https://github.com/RocketChat/Rocket.Chat.Apps-engine/pull/162 and fixes #161
Codecov Report
Merging #268 into alpha will increase coverage by
1.94%. The diff coverage is100.00%.
@@ Coverage Diff @@
## alpha #268 +/- ##
==========================================
+ Coverage 53.05% 54.99% +1.94%
==========================================
Files 74 82 +8
Lines 2754 2873 +119
Branches 408 408
==========================================
+ Hits 1461 1580 +119
Misses 1293 1293
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/server/compiler/AppCompiler.ts | 26.03% <ø> (ø) |
|
| src/server/accessors/RoomRead.ts | 100.00% <100.00%> (ø) |
|
| src/server/accessors/ServerSettingRead.ts | 100.00% <100.00%> (ø) |
|
| src/server/errors/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/storage/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/accessors/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/logging/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/bridges/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/managers/index.ts | 100.00% <0.00%> (ø) |
|
| src/server/marketplace/license/index.ts | 100.00% <0.00%> (ø) |
|
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d3fe543...78195e5. Read the comment docs.