Rocket.Chat.Apps-engine icon indicating copy to clipboard operation
Rocket.Chat.Apps-engine copied to clipboard

(re)move all apps invocations to inside the framework

Open ggazzo opened this issue 6 years ago • 5 comments

just a suggestion, change

if (Apps && Apps.isLoaded()) {
		Apps.getBridges().getListenerBridge().roomEvent('IPostRoomDeleted',room);
}

to

Apps.roomEvent('IPostRoomDeleted',room);

ggazzo avatar Feb 20 '19 14:02 ggazzo

@ggazzo @Sing-Li @rodrigok @d-gubert Can I work on It. :smile: thanks : )

avsingh999 avatar Mar 08 '19 15:03 avsingh999

@ggazzo I am closing this due to us needing to make these checks since the entire Apps Framework can be disabled via a setting.

graywolf336 avatar Jun 07 '19 19:06 graywolf336

@graywolf336 can't we check this inside the event call, that way RC doesn't need to know and check if the Apps is enabled or not?

rodrigok avatar Jun 08 '19 14:06 rodrigok

IMO it looks totally feasible to move them to somewhere else, like an apps dedicated event bus... or even a RC wide event bus :eyes:

Unless I'm missing something

d-gubert avatar Jun 10 '19 17:06 d-gubert

I don't like to call the same chain methods multiple times line by line, doesn't make sense to me, these methods could be invoked internally...

ggazzo avatar Jun 10 '19 17:06 ggazzo