Rocket.Chat.Apps-engine
Rocket.Chat.Apps-engine copied to clipboard
(re)move all apps invocations to inside the framework
just a suggestion, change
if (Apps && Apps.isLoaded()) {
Apps.getBridges().getListenerBridge().roomEvent('IPostRoomDeleted',room);
}
to
Apps.roomEvent('IPostRoomDeleted',room);
@ggazzo @Sing-Li @rodrigok @d-gubert Can I work on It. :smile: thanks : )
@ggazzo I am closing this due to us needing to make these checks since the entire Apps Framework can be disabled via a setting.
@graywolf336 can't we check this inside the event call, that way RC doesn't need to know and check if the Apps is enabled or not?
IMO it looks totally feasible to move them to somewhere else, like an apps dedicated event bus... or even a RC wide event bus :eyes:
Unless I'm missing something
I don't like to call the same chain methods multiple times line by line, doesn't make sense to me, these methods could be invoked internally...