EmbeddedChat icon indicating copy to clipboard operation
EmbeddedChat copied to clipboard

Fixed useEffect dependencies in useMediaRecorder hook

Open sbsangu opened this issue 1 year ago • 2 comments
trafficstars

Resolve useEffect dependencies in useMediaRecorder hook

Acceptance Criteria fulfillment

  • [X] Include all necessary dependencies in the useEffect hook of the useMediaRecorder hook.
  • [X] Ensure proper cleanup is performed when the component unmounts or when dependencies change.
  • [X] Test that the lifecycle of the media recorder is managed correctly

Fixes #574

Video/Screenshots

Screenshot 2024-06-02 011323

sbsangu avatar Jun 01 '24 19:06 sbsangu

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 01 '24 19:06 CLAassistant

LGTM ! Can you please attach a video showing that both audio and video recorder is working fine after this change?

Spiral-Memory avatar Jun 03 '24 10:06 Spiral-Memory

Hey @sbsangu Could you please upload a video showing everything works fine after this change?

Spiral-Memory avatar Sep 29 '24 08:09 Spiral-Memory

Screenshot_2024-10-06-16-02-23-46_e4424258c8b8649f6e67d283a50a2cbc

Camera not working !

Spiral-Memory avatar Oct 06 '24 10:10 Spiral-Memory