vue-popper
vue-popper copied to clipboard
vue-popper wraps components in span, while this is not always desirable
vue-popper wraps components in span, while this is not always desirable
It's not ok if child elements are div. Div is block element, span is inline, div's can't be inside spans Maybe make wrapper type configurable?
This PR adds this option https://github.com/RobinCK/vue-popper/pull/94
I think this is still an open issue, actually. Looked at the PR that @alfonsobries provided, which is one step to solving the problem, but that only provides a way of overriding one of two possible <span>s.
There's still a hard-coded <span> wrapping the default slot. My guess is this is likely due to use of the v-show directive.
If a v-if directive were used, you could substitute a <template> tag instead, but then it has to be re-rendered every time the display is affected.
I'll try to tinker around a bit, but I don't see any reason why we couldn't also use the <component :is="tagName"> in place of the remaining hard-coded <span> tag.
this good idea, welcome to pr