Robbie Wagner

Results 813 comments of Robbie Wagner

I tried forking this repo and tweaking options as @vrwebdesign suggested, but it didn't seem to make a difference.

@YoranBrondsema I no longer have permissions to this repo. If @yowainwright would be interested in giving them back to me, I would be happy to review and continue maintaining this...

@yowainwright any interest in adding me back as a maintainer here? Would love for the DSC addons to not die out.

@hakubo they are cleaned up on their own https://github.com/dollarshaveclub/ember-responds-to/blob/master/addon/mixins/responds-to-scroll.js#L28 Is there a need for removing before that? I'm a bit confused here.

@hakubo do you have a suggestion on how we would have an API that was any cleaner than just using `window.removeEventListener('scroll', this.scrollHandler);`? I'm not opposed to this, I'm just not...

@hakubo If you just want to manually add and remove listeners, shouldn't that be out of the scope of this addon? This addon is made to wire these things up...

@yowainwright the benefit is to require slashes in urls for static sites. I'm using prember, which needed this tweak. `includes` is totally fine and supported in node 4+. Ember is...

Ember has now dropped node 4 support as well, so this should be good to go. If you guys are open to it, I can open a PR.

@snewcomer yeah, would need a way to turn it off and on

@snewcomer any thoughts on if we want to implement this? At the very least, we could document how to do this in the README.