Robbie Wagner

Results 813 comments of Robbie Wagner

@vlascik thanks for taking on this work! It is long overdue. I would recommend ignoring lint issues for now. It would be good to get these tests running and see...

@mixonic yeah on 5.0.0. ember-cli-sass is a devDep, yeah, but my guess is because this is an scss file it causes issues https://github.com/Addepar/ember-table/blob/master/app/styles/ember-table/default.scss When I install `ember-table` and run `ember...

@evoactivity I am using pnpm and it works fine with https://github.com/shipshapecode/swach. Do you have steps to reproduce?

@evoactivity I think this is an Electron issue, not specific to ember-electron. I encountered the issue myself trying to build a new version. Something with symlinks and pnpm moving node_modules...

@basz I use TypeScript for the Ember side, but not the Electron side.

@jelhan you are correct that support was dropped for it. I believe tree shaking should be automatic with embroider and only use the things you import, but I could be...

> > I believe tree shaking should be automatic with embroider and only use the things you import, but I could be wrong. > > That's only true _if_ consuming...

I think documenting the breaking change is probably the best way to go here.

@jelhan perhaps something in latest Ember broke things? The types are working for us in Ember 3.28

> @RobbieTheWagner I'm using the types shipped with Ember 5.4. I assume you are using types from DefinitelyTyped with Ember 3.28. That may explain the difference. Even so, this addon...