Robbie Wagner

Results 813 comments of Robbie Wagner

> @rwwagner90 perhaps just in the Tour constructor? Seems logical

Perhaps try wrapping in a position relative div or putting one inside? I'm not sure what causes this, but my guess is there are workarounds.

@sdraper69 I personally prefer to do things the opposite way. I would make my select have an action that calls `tour.next()` when appropriate.

@sdraper69 you are doing basically the same bindings either way, it's just different syntax. If you would like to open a PR implementing what you are suggesting, we would be...

@EmNicholson93 we should make sure our docs are correct here. This issue is saying we are not setting `data-shepherd-active-tour` like we say we are in the docs. Can we confirm?

@EmNicholson93 Do you happen to know the PR or commit where it was all removed? I cannot recall why we removed it, but if we definitely want it gone, then...

@EmNicholson93 yes, it appears we did remove all that. I think to close this ticket then we should remove all that from the docs.

@EthraZa that should not be the case. We set the active tour to null in `_done` here https://github.com/shipshapecode/shepherd/blob/master/src/js/tour.js#L297 Hidden tours I would expect to still be active, but cancelled or...

@doug0102 I am not sure I understand what you mean here. We have a11y baked into Shepherd and force tab to only do the Shepherd elements so you are focus...

@doug0102 we definitely want to make things correct for all a11y cases. If you have some guidance on what is wrong and how to fix it or would like to...