Robbie Wagner

Results 813 comments of Robbie Wagner

@monshan would it be possible to add some tests for these new options? I don't think new tests were added here right?

@monshan yeah, that sounds perfect! Basically just testing at least a couple different values and making sure it moves.

@monshan any updates on those tests? Would love to merge this soon 😄

@shaifulborhan we currently use just one number for all sides, as you can see here https://github.com/shipshapecode/shepherd/blob/0eda0762c30d373e4e4cac1910a3417f8764e554/src/js/components/shepherd-modal.svelte#L56-L59 I would be open to allowing specifying different amounts per side, if you have...

@thejimbirch you can override `scrollTo` on the step to change the scrolling behavior if that's what you mean?

@thejimbirch do you know of a good way to use that with `scrollIntoView`?

@michaelrampl I am able to scroll the page just fine on iOS on https://shepherdjs.dev/ The part that is not scrollable is the highlighted target. Do you have a target that...

@EmNicholson93 yeah, I just didn't know exactly how to implement it, but we should figure out a way to have this library do nothing when running server side, since it...

@chuckcarpenter I don't think that's necessarily reliable. I think `window` exists in jsdom and some things that are not _real_ clients. I'm also not sure at what place in Shepherd...

> @rwwagner90 that's how Next.js does the SSR check, seems to work for them. Fair enough. Any thoughts on where that check would go in Shepherd?