Robbie Wagner
Robbie Wagner
> @rwwagner90 I thought the scope of this one would just be to rebase it which went through but still not passing. If I remember right its because this change...
@EmNicholson93 I think this needs some refactoring to be compliant with the new `attachTo.element` API. Can you please take a look?
@wbobeirne there have been requests to set these things separately before. I would certainly be open to a PR if you would like to add this feature!
@trish1400 this is definitely a known issue. I think the problem is buttons can do anything you want, as you mentioned, so we cannot assume which ones will be next/back...
We should probably make `next` and `previous` buttons special cases, instead of allowing custom logic for all buttons. Then we could handle this in the library.
@wbobeirne glad to hear you are loving Shepherd! Perhaps there is something I am missing here, but couldn't you just target the parent of your list of unknown size? Then...
@wbobeirne thanks for the explanation! I think it is reasonable to support what you are asking about. Would you be interested in opening a PR?
@timodwhit looks like we have a failing test here. Mind taking a look?
@monshan would you be able to look into this?
Awesome, thanks @monshan!