Robbie Wagner

Results 813 comments of Robbie Wagner

@cah-briangantzler I will have to check again, but we are trying to do `this.server.create` in `beforeEach` not in a test, so perhaps the `beforeEach` has a different context?

@cah-briangantzler I stepped through things again, `this` appears to be a test: However, despite it definitely hitting the line where it does `this.server =` it never sets `this.server`.

Ah, I finally figured out the issue! `this.server = (0, _startMirage.default)(this.owner, options)` was actually erroring. Once I moved an import for `association` to `miragejs` instead of `ember-cli-mirage` everything worked. I've...

I would argue for adding eslint-plugin-node, like ember does by default. Thoughts?

@bendemboski I think documenting would be an adequate fix here. Linting is very personal to most folks anyway, so forcibly editing their config may not be what we want anyway.

@kstinson14 I realize this is super old, but could you please rebase and fix conflicts?

@krasnoukhov I know this has been open awhile. Any chance you could rebase and resolve the conflicts please?

@camskene I realize this is super old, but could you please rebase and fix conflicts?

@jacobq I think we should add a section for CI and code signing. I have mac signing working on GitHub actions, and hope to get Windows signing working soon. It...

@bendemboski for the Ember app, wouldn't it be the same as any other Ember app?