Robbe Sneyders

Results 203 comments of Robbe Sneyders

Thanks @carloscbl! Tests are failing though. Not sure if this is due to an issue with your code, or because the failing tests depend on the old behavior.

Hi @alfechner, This is indeed a conscious decision. The reason not to do this by default, is because it requires us to intercept the request body in middleware, modify it,...

I do not use VSCode myself, but would welcome a PR adding this by someone that does.

Thanks for the report @chrisinmtown. I would propose a different fix though. Seems like we're losing the stacktrace info since [we're running the sync function in a threadpool](https://github.com/spec-first/connexion/blob/1844a2fb3f1d09a37edfeab7a7200d52e97abbd9/connexion/middleware/exceptions.py#L39), which is...

The error handler is being called from an `async` context. If the error handler is `async`, it is called using `await`. If it is not `async`, it is executed in...

Looking at Starlette and FastAPI, they seem to have the same issue. It's probably safest to keep running the sync handlers in a threadpool, since people might be logging errors....

Please see #1757 > I would be happy to accept a PR that makes Connexion 2 compatible with newer Werkzeug versions without making any breaking changes to Connexion itself. Although...

The first step would indeed be to get the tests green without any additional changes. The last v2 release was almost 2 years ago though, so I would not be...

I recommend running the v2 test suite with the old version of setuptools and other test dependencies and fixing any failing tests. If the tests are green again, you can...