BackwardCompatibilityCheck icon indicating copy to clipboard operation
BackwardCompatibilityCheck copied to clipboard

Phar release is not created

Open asgrim opened this issue 3 years ago • 7 comments

As per:

https://twitter.com/s_bergmann/status/1475014835129757699

Looks like the "release-phar" action did not run (can't verify, I'm on phone)

It should be triggered by creating the release. However, my guess is that because we're using laminas/automatic-releases, downstream events are not triggered due to the GitHub access token being used. It might be possible to switch this out to use the personal access token for the organisation, which would cause downstream events to trigger actions in turn.

https://docs.github.com/en/actions/reference/authentication-in-a-workflow#using-the-github_token-in-a-workflow

When you use the repository's GITHUB_TOKEN to perform tasks on behalf of the GitHub Actions app, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

asgrim avatar Dec 26 '21 08:12 asgrim

The token for the release is mine though: we should be fine.

We could copy https://github.com/maglnet/ComposerRequireChecker/blob/28d7833f000667fd90ae2d38b19cf670593af190/.github/workflows/phar-creation.yml to fix this.

Ocramius avatar Dec 26 '21 12:12 Ocramius

Sorry for bothering: ping.

sebastianbergmann avatar May 08 '22 05:05 sebastianbergmann

Should phar be attached release asset here? When I will have time I might be willing to help to debug this one. image

Legion112 avatar Dec 02 '22 09:12 Legion112

Should phar be attached release asset here?

Yes, please. This is where Psalm, for instance, publishes their PHARs: https://github.com/vimeo/psalm/releases/tag/5.6.0

sebastianbergmann avatar Jan 24 '23 14:01 sebastianbergmann

Any update on this? Thanks!

sebastianbergmann avatar Dec 05 '23 13:12 sebastianbergmann

Nobody worked on Phar releases anymore, sorry: unlikely happening unless someone else proposes a patch for it.

Ocramius avatar Dec 05 '23 15:12 Ocramius

Just made a proposal using Nix at https://github.com/Roave/BackwardCompatibilityCheck/pull/754

drupol avatar Dec 05 '23 17:12 drupol