support icon indicating copy to clipboard operation
support copied to clipboard

Published 20 hours ago • verified publisher icon ReviewNB

Approve and merge pull requests

Open itaykrk opened this issue 5 years ago • 2 comments

Currently i'm using ReviewNB to review PRs and then get back to github to approve the PR and merge to the master branch. It would be great if you'll add the option to approve and merge PRs directly from ReviewNB.

itaykrk avatar Mar 24 '20 13:03 itaykrk

@itaykrk Thank you. I think "Approve & Merge PR" would be a good button to have on ReviewNB. I just checked that there's an API support available for this as well.

I have marked this as a feature request & will build it in (can't promise any timeline at the moment).

amit1rrr avatar Mar 24 '20 16:03 amit1rrr

Additionally, it would be great if we can handle notebook merge conflicts at PR merge time. Be smart enough to automatically handle simple conflicts (e.g. if only metadata is conflicting then no need for human intervention) & offer UI for complicated notebook merges.

amit1rrr avatar May 24 '21 11:05 amit1rrr