rcheevos icon indicating copy to clipboard operation
rcheevos copied to clipboard

Add Gamecube to hash initialize iterator for iso format

Open bozothegeek opened this issue 1 year ago • 2 comments

Just to add Gamecube now for 'iso' format in hash initialization for iterator. Thanks in advance for this merge. Tested in pixL (new retro OS ;-)

bozothegeek avatar Jul 16 '24 13:07 bozothegeek

See for example of result when hash matched well now with any new retroarchivements for gamecube in this OS using pegasus-frontend and a modified GameOS theme including RA display... image

bozothegeek avatar Jul 16 '24 13:07 bozothegeek

Please also update the test_hash_gamecube function to initialize an iterator and validate the new code path.

Jamiras avatar Jul 17 '24 00:07 Jamiras

@bozothegeek - have you had a chance to look at the unit test suggestion?

Jamiras avatar Jul 25 '24 02:07 Jamiras

@bozothegeek - have you had a chance to look at the unit test suggestion?

OK, I will check... sorry, I just saw your reply ;-)

bozothegeek avatar Aug 06 '24 17:08 bozothegeek

Hi @Jamiras It's done, I updated the unit test test_hash_gamecube as expected, thanks in advance

bozothegeek avatar Aug 06 '24 19:08 bozothegeek

@Jamiras Thanks ;-)

bozothegeek avatar Aug 23 '24 15:08 bozothegeek