ro-crate icon indicating copy to clipboard operation
ro-crate copied to clipboard

Missing entity from workflow example, or spec needs clarifying.

Open fbacall opened this issue 6 years ago • 1 comments
trafficstars

Describe the bug The workflow RO crate example refers to { "@id": "README.md" } in its hasPart, but there is no entity with that @id in the @graph. Is this valid?

URL https://github.com/ResearchObject/ro-crate/blob/master/examples/workflow-0.2.0/ro-crate-metadata.jsonld#L79

Suggested fix Add an entity for the README file, or clarify in the spec that this is a valid scenario.

Additional context The spec mentions:

Where files and folders are represented as Data Entities in the RO-Crate JSON-LD, these MUST be linked to, either directly or indriectly, from the Root Data Entity using the hasPart property.

but it is not clear if the inverse is true.

fbacall avatar Oct 29 '19 09:10 fbacall

I think all the data entities in hasPart should also be represented in the @graph - do you agree @ptsefton ?

stain avatar Oct 31 '19 10:10 stain