requestNetwork icon indicating copy to clipboard operation
requestNetwork copied to clipboard

chore(payment processor): remove stream payment

Open benjlevesque opened this issue 2 years ago • 3 comments

experiment to see the impact of the sf sdk

benjlevesque avatar Oct 03 '23 21:10 benjlevesque

What would motivate us to remove stream payments?

MantisClone avatar Oct 05 '23 12:10 MantisClone

@MantisClone the rn library has way too many dependencies, we need to rethink its architecture I believe.

From the top of my mind, some of the issues:

  • it's very heavy, causing issues for Frontend use
  • importing the library has an important impact on process startup (very visible on unit tests)
  • the dependencies are chaotic, we can't upgrade one without breaking 10 others

I believe the payment packages (detection and processor) should be split per ecosystem (NEAR, EVM...) / vendor (SF) /... and injected into the Request client instead having them loaded by default . Alternatively we could dynamically load them but that's less flexible.

This would enable having a dapp that only does evm payments without loading the whole mess, or having apps / backend focusing on non-payment parts.

The superfluid SDK isn't directly responsible, I'm simply trying to see more clearly the state of our dependencies

benjlevesque avatar Oct 05 '23 17:10 benjlevesque

@skiv71 and I agree that the dependencies are a mess. Thank you, @benjlevesque, for taking the time to look into it more deeply! :pray: I'm definitely open to refactoring to reduce coupling between packages. :+1: I hesitate to remove streaming entirely :thinking:

MantisClone avatar Oct 06 '23 20:10 MantisClone

closing, not absolutely required. This was an experiment. Feel free to re-open if it's needed

benjlevesque avatar Apr 23 '24 08:04 benjlevesque