reproman icon indicating copy to clipboard operation
reproman copied to clipboard

retrace should not demand presence of all the dependencies

Open yarikoptic opened this issue 8 years ago • 3 comments
trafficstars

Now it dives into Resource manager which tries to get all the docker/boto3(aws) etc modules for its support. Since those aren't needed for retracing within a (local) session, should not be imported

yarikoptic avatar Oct 11 '17 14:10 yarikoptic

@kyleam could you please look into this one?

yarikoptic avatar Jun 14 '18 19:06 yarikoptic

Hmm, #243 (which closed #211) fixed this, in the sense that the retrace call doesn't fail if, e.g., boto3 isn't installed. @yarikoptic, would you prefer that docker/boto3 etc aren't imported at all or are you OK with the current state (catching the ImportError and not failing)?

kyleam avatar Jun 25 '18 12:06 kyleam

Ideally (but I do not remember if it was feasible) we shouldn't import modules which aren't needed, e.g. boto3 merely for tracing. But I've not looked yet if it could be achieved in a reasonable fashion ;)

yarikoptic avatar Jun 25 '18 14:06 yarikoptic