neurodocker icon indicating copy to clipboard operation
neurodocker copied to clipboard

Published 20 hours ago • verified publisher icon ReproNim

afni.yaml

Open a3sha2 opened this issue 4 years ago • 4 comments

the gsl is breaking the afni because the gsl lib has been updated from 19 to 23 gsl2_path="$(find / -name 'libgsl.so.23' || printf '')"

a3sha2 avatar Jun 27 '21 16:06 a3sha2

hi @a3sha2 - thank you very much for the report. libgsl will have a different version across different versions of linux distributions... i'm wondering if we should glob like this:

 gsl2_path="$(find / -name 'libgsl.so.*' || printf '')"

what do you think?

kaczmarj avatar Oct 15 '21 19:10 kaczmarj

@kaczmarj thank you that will do the job

a3sha2 avatar Oct 16 '21 17:10 a3sha2

@a3sha2 - thanks. we went through a refactor during the timeline of this PR. could you rebase to the current master branch? or can you open a new pr against the current master?

kaczmarj avatar Oct 16 '21 20:10 kaczmarj

I was about to integrate this pull request in the current fix, but it looks like it is already there?

    gsl_path="$(find / -name 'libgsl.so.??' || printf '')"

stebo85 avatar Jul 08 '22 23:07 stebo85

pull request obsolete and change is already there: https://github.com/ReproNim/neurodocker/blob/bd4ce3a33142530a1c98fc3499ba56d6465151ab/neurodocker/templates/afni.yaml#L82

stebo85 avatar Aug 22 '23 06:08 stebo85