vue-highlighter icon indicating copy to clipboard operation
vue-highlighter copied to clipboard

Published 20 hours ago • verified publisher icon Remeic

switch build to rollup from bili

Open khamer opened this issue 5 years ago • 4 comments

To address Issue #26. I tested using the esm, cjs, and iife (with vue from the cdn) using Parcel locally. Let me know if it needs any changes or you're seeing any issues and I'll get them fixed.

khamer avatar Oct 03 '20 20:10 khamer

Hi @khamer, thanks for this PR, can remove even "babel-preset-poi": "^10.0.2" and use @babel/preset-env Please make attention to presets on babel config!

Remeic avatar Oct 04 '20 11:10 Remeic

Hey @Remeic - I think I've made the changes you were looking for. It's now using @babel/preset-env and I did the recommended steps for libraries and used @babel/plugin-transform-runtime as well. npm test fails but it fails for me even without the PR too, so I'm not sure if that's being used.

khamer avatar Oct 05 '20 00:10 khamer

Hey @Remeic - is there something else you're looking for here? Happy to make more changes.

khamer avatar Oct 25 '20 03:10 khamer

I wish add hacktoberfest accept label just in time, sorry for delay i have a lot of work to do in these days. @khamer if in future you want to check the failing test you make me very happy!

Remeic avatar Oct 31 '20 20:10 Remeic