vue-highlighter icon indicating copy to clipboard operation
vue-highlighter copied to clipboard

Published 20 hours ago • verified publisher icon Remeic

Case insensitive search

Open dangilkerson opened this issue 6 years ago • 3 comments

Partial fix for Fuzzy matching #13

Will do fuzzy searching next

dangilkerson avatar Oct 14 '19 15:10 dangilkerson

Please approve

ashnegi avatar Sep 23 '20 09:09 ashnegi

Hi @dangilkerson, thanks for opening this PR, any contribution is very fundamental for us. There is a problem with this PR, replacing 'g' with 'gi' the insensitive search is now enabled and can't turned off.

I suggest to refactor the option for a case sensitive search and allow users to choose the best option for them. For any suggestion or doubt don't hesitate to contact us

Remeic avatar Oct 02 '20 09:10 Remeic

Hi @dangilkerson, thanks for opening this PR, any contribution is very fundamental for us. There is a problem with this PR, replacing 'g' with 'gi' the insensitive search is now enabled and can't turned off.

I suggest to refactor the option for a case sensitive search and allow users to choose the best option for them. For any suggestion or doubt don't hesitate to contact us

Remeic avatar Oct 02 '20 09:10 Remeic