Rémi Delaporte-Mathurin

Results 247 comments of Rémi Delaporte-Mathurin

Hi @bruceey42 Glad you like this tool! This was indeed on my todo list. I'm not sure about the "planned" status cause for many of these (DEMO, K-DEMO, ARC, ...)...

There is a random error ocuring on both conda and docker when running test_xdmf.py. Although it seems that all the tests pass in this file so I don't really know...

The error that we are seeing here might be related to https://github.com/FEniCS/dolfinx/issues/3162 We'll wait for a fix before merging this

I've narrowed down the error to using ``` my_model.solver.convergence_criterion = "incremental" ksp = my_model.solver.krylov_solver opts = PETSc.Options() option_prefix = ksp.getOptionsPrefix() opts[f"{option_prefix}ksp_type"] = "cg" opts[f"{option_prefix}pc_type"] = "gamg" opts[f"{option_prefix}pc_factor_mat_solver_type"] = "mumps" ksp.setFromOptions()...

MWE to reproduce the random segmentation fault ```python import numpy as np import festim as F from petsc4py import PETSc for i in range(2): my_model = F.HydrogenTransportProblem() my_model.mesh = F.Mesh1D(np.linspace(0,...

I noticed that removing the lines ``` my_model.solver.convergence_criterion = "incremental" ksp = my_model.solver.krylov_solver opts = PETSc.Options() option_prefix = ksp.getOptionsPrefix() opts[f"{option_prefix}ksp_type"] = "cg" opts[f"{option_prefix}pc_type"] = "gamg" opts[f"{option_prefix}pc_factor_mat_solver_type"] = "mumps" ksp.setFromOptions() ```...

What do you think? Would it be better to use the fenics logging system or rather make our own with maybe different levels?

> Though, it's a tough question. I think we can re-create log levels 50, 40, 30, and probably 20, whereas 16, 13, 10 - I haven't tested/used a lot yet....

Yes we don't want to make our own errors like this. But what we want is for users to have enough information about what is going on (eg. Defining boundary...

I think we need to sit down and: 1) clearly define what we want to read. For instance: know if the stepsize is shrunk or relaxed, know if a field...